Mariyan Dimitrov
Mariyan Dimitrov
I thought gh would let me create two consecutive PRs but that didn't happen, notes to the "second" PR and functionality: This feature introduces the option for integration testing of...
Hey @neoaggelos thanks a lot for your feedback, really appreciate it! I'll just start bottom to top answering the questions: > @merkata Is there a particular reason why you decided...
Closing due to lack of review.
> @merkata this change set looks great to me, could you resolve the conflicts in the PR and add test cases for the new tagging feature? Thanks a lot @ellisonc...
> > > @merkata this change set looks great to me, could you resolve the conflicts in the PR and add test cases for the new tagging feature? > >...
> @merkata apologies for the delay, I attempted to fix the conflicts and get this merged but our tooling doesn't allow pushes to any branch named master and I don't...
> @merkata I also don't see the readme update you mentioned, did that not get staged? I didn't explain it accurately - I updated the old version of the README.md,...
> @merkata I see what you're saying. How about adding a new section header under the [`Excluding Resources by Age`](https://github.com/gruntwork-io/cloud-nuke#excluding-resources-by-age) header (or maybe right above it?) @zackproser sorry I wasn't...