Marcel

cleanup(bazel): convert googleapis system includes to normal ones

8

Manually removed the `googleapis_system_includes` target from `googleapis.modules.patch` and `BUILD` dependencies. The remaining changes to C++ files have been generated with the following commands find . -type f -exec sed -i...

Use more Bazel module dependencies

1

This allows bzlmod version resolution and avoids ODR violations when importing the same dependency multiple times in different modules.

Default overrides not taken into account when using `bazel_dep()`

13

Consider the following `MODULE.bazel`: ```starlark module(name = "test") bazel_dep(name = "rules_go", version = "0.54.0") go_sdk = use_extension("@rules_go//go:extensions.bzl", "go_sdk") go_sdk.download(version = "1.24.2") bazel_dep(name = "gazelle", version = "0.43.0") go_deps = use_extension("@gazelle//:extensions.bzl",...

For example: ``` /path/to/cyclonedds/src/core/ddsc/include/dds/dds.h:759:5: error: declaration is marked with '@deprecated' command but does not have a deprecation attribute [-Werror,-Wdocumentation-deprecated-sync] 759 | * @deprecated Get enabled status on entity. Use \ref...

Build everything in CI

2

Currently, the CI only runs `bazel test //...`: https://github.com/mvukov/rules_ros2/blob/bee646840d2e851e27898f37c5eb0a000a81718d/.github/workflows/test.sh#L9-L10 and together with `--build_tests_only` in `.bazelrc`: https://github.com/mvukov/rules_ros2/blob/bee646840d2e851e27898f37c5eb0a000a81718d/.bazelrc#L40 many targets are broken with Bzlmod. It would be great if those targets would...

TODO error: ``` Traceback (most recent call last): File "HOME/.cache/bazel/_bazel_USER/20b68613c9f8625c17233ca1da189885/sandbox/linux-sandbox/7343/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/xacro+/xacro_main.runfiles/xacro+/xacro/__init__.py", line 1027, in parse inp = f = open(os.path.join(root_dir, filename)) FileNotFoundError: [Errno 2] No such file or directory: 'bazel-out/k8-fastbuild/bin//TMP_XACRO/test_with_params/ros2/test/xacro/test_with_params.urdf.xacro ```...

Currently the `fs.FS.Open()` call returns an `fs.File` interface which does provide the `.Seek()` method. Return an interface inheriting from both `fs.File` _and_ `io.Seeker` and provide the `.Seek()` method in the...

Consider `foo/BUILD`: ```starlark # gazelle:proto_strip_import_prefix /portal/protos ``` Gazelle prints the following error: ``` gazelle: proto_strip_import_prefix "/foo/bar" not in directory foo ``` Obviously `foo/bar` is in the directory `foo`, so this...

I am trying to migrate `rules_ros2` to use the Bazel rules from this repo. See mvukov/rules_ros2#475. Unfortunately, I get a `FileNotFoundError`.