Robert
Robert
FEATURE: Add Instant Run-off Voting to Poll Plugin (Part 1: migrate existing plugin to Glimmer only)
thanks for all the effort to provide review, your patience, great suggestions and those contributions, really appreciated!! @ZogStriP @jjaffeux @gschlager 🙏❤️
FEATURE: Add Instant Run-off Voting to Poll Plugin (Part 1: migrate existing plugin to Glimmer only)
Apologies, @tgxworld, looks like two tests and a single issue. I'll follow up.
@jjaffeux thanks for jumping on to review, appreciated. I've converted all Components to .gjs. Surprisingly _not_ as trivial as expected. So many Imports and subtle changes to e.g. actions 😅
@jjaffeux I believe I've addressed all your points for now.
@tgxworld I could try! 😅 With hindsight it definitely makes sense, though I was trying to avoid submitting a "refactoring only" PR as per your contribution policy 😅 Perhaps I...
@jjaffeux , @tgxworld just so I'm clear: * I will keep this PR open which will become PR number 2. Once all current raised issues are resolved, we will temporarily...
FYI I've just merged in main to ensure #27204 conflicts were resolved. cc: @ZogStriP @jjaffeux
@jjaffeux responded to all your feedback thus far
@CvX that makes a lot of sense. Thanks for the PR. I have a couple of urgent matters to take care of but will get to that in due course.
@CvX thanks for you PR, merged. I really like this change. If we ever offer additional ranked choice algo's in future, this is a really nice generalisation for areas where...