discourse FEATURE: Add Instant Run-off Voting to Poll Plugin (Part 1: migrate existing plugin to Glimmer only)

The "migration to Glimmer" has been broken out here from #27155 as requested here to make the review process less onerous and reduce change risk:

DEV: migrates most of the widget code to Glimmer in prep for IRV additions
NB This already incorporates significant amounts of review and feedback from the prior PR.
NB because there was significant additional feedback relating to older Poll code that I've improved with feedback, there are some additional changes here that are general improvements to the plugin and not specific to IRV nor Glimmer!
There should be no trace of IRV code here.

Once this is finalised and merged we can continue to progress with #27155.

(as requested @tgxworld) (cc: @jjaffeux, @gschlager )

May 27 '24 14:05 merefield

@merefield looks like there's a conflict. Can you ping me once you've fixed it and I'll merge this 👍

Jul 04 '24 08:07 ZogStriP

@ZogStriP thanks. Can you point me to the conflict?

Jul 04 '24 10:07 merefield

thanks for all the effort to provide review, your patience, great suggestions and those contributions, really appreciated!! @ZogStriP @jjaffeux @gschlager 🙏❤️

Jul 04 '24 12:07 merefield

@merefield It seems like this change has resulted in some tests to become flaky. Would you be able to have a look as to why that is the case?

I have skipped those tests for now in https://github.com/discourse/discourse/pull/27728

Jul 05 '24 02:07 tgxworld

Apologies, @tgxworld, looks like two tests and a single issue.

I'll follow up.

Jul 08 '24 07:07 merefield