Kristoffer K.

Results 179 comments of Kristoffer K.

That's some great feedback @evanw, could you make it in https://github.com/yarnpkg/berry/pull/4671 instead/as well so readers of that PR can see it?

Ah, that's totally fine, feel free to hide these three comments to not distract from the discussion 👍

That shouldn't be an issue anymore, the problem is that it runs the following invalid command ```sh yarn --frozen-lockfile run build:website:en ```

> @merceyz We are currently using Yarn canary, but the build size report action is still failing when running `yarn --frozen-lockfile run build:website:en`. Is [preactjs/compressed-size-action#41](https://github.com/preactjs/compressed-size-action/pull/41) really not needed? Sort of,...

> I wonder if it's necessary to actually add @docusaurus/theme-classic to the dependencies? To an average user it may be confusing why this is needed, because this dependency is kind...

You can try running the following command and see if it gives you some more details. ```sh PNP_DEBUG_LEVEL=1 yarn tsc ```

> I wasn't aware that Yarn 3.1 doesn't really/fully implement ESM imports NIT: It does but it isn't enabled unless the entrypoint is also ESM, the 3.2 version will enable...

For what it's worth; we've added an e2e test in the Yarn repo verifying that the Angular CLI and PnP work https://github.com/yarnpkg/berry/pull/3949

> It seems to be an issue with with @storybook/preset-create-react-app. https://github.com/storybookjs/storybook/issues/13428#issuecomment-1082566162 @shilman I noticed some dependency issues with that package in https://github.com/yarnpkg/berry/pull/3004 (specifically https://github.com/yarnpkg/berry/commit/a7fd51af9b9ef70a26163d6b457bb4fd83012674), I've been meaning to open a...

Not yet, we'll also need to skip all big-endian platforms as that's currently not supported. The `git diff` related tests failing is a bit odd.