David (Mengqi) Yu

Results 81 comments of David (Mengqi) Yu

Sorry for the late reply. The behavior I expect: Whenever an item in the sidebar hierarchy has children items, it should display an expand/collapse toggle. It should NOT treat it...

> It is triggered by gopkg.in/yaml.v2 aka https://github.com/go-yaml/yaml The issue I have is triggered by this library too. We are using a forked version of `https://github.com/go-yaml/yaml`. But I believe there...

Just tried with the new release v0.24.0 and got a similar error. ``` $ tinygo build -o set-ns.wasm -target wasi ./main.go # sigs.k8s.io/kustomize/kyaml/internal/forked/github.com/go-yaml/yaml /usr/local/lib/tinygo/src/reflect/type.go:385:15: (reflect.Type).Elem() called on map type =...

I needs golang 1.18+ in https://github.com/GoogleContainerTools/kpt/pull/3450. ``` # github.com/prep/wasmexec Error: ../../../go/pkg/mod/github.com/prep/[email protected]/js.go:12:34: undefined: any Error: ../../../go/pkg/mod/github.com/prep/[email protected]/js.go:40:19: undefined: any Error: ../../../go/pkg/mod/github.com/prep/[email protected]/js.go:44:35: undefined: any Error: ../../../go/pkg/mod/github.com/prep/[email protected]/js.go:55:30: undefined: any Error: ../../../go/pkg/mod/github.com/prep/[email protected]/js.go:64:13: undefined: any Error:...

Some items in https://github.com/GoogleContainerTools/kpt/issues/2504#issuecomment-919414489 may be related.

@mortent @droot This PR is not a small changed to kpt's fork of cli-utils. What is our plan about this fork going forward? IMO we should keep our fork as...

> I think sending the go 1.19 and ioutil -> os changes separately would help make this much more reviewable. These changes are really from https://github.com/GoogleContainerTools/kpt/pull/3447. I cherry picked the...

I just realized that a few comments have not been addressed. I missed them until I resolved other comments. I will resolve them tomorrow. Meanwhile the PR is mostly ready...

Features: - Support Starlib (e.g. json, yaml) [**Done** in GoogleContainerTools/kpt-functions-catalog#570. Released in v0.3.0] - Enable optional features (e.g. recursion) [**Done** in GoogleContainerTools/kpt-functions-catalog#572. Released in v0.3.0] - Starlark function generator (wrapper)...