Michael

Results 10 comments of Michael

I've done the work needed to support this (by clicking the headers) in Plasma here: https://github.com/matter-ecs/plasma/pull/5.

CI will pass with https://github.com/matter-ecs/matter/pull/89

> I am unsure, so I didn't mention anything in review, but it seems like we fail at tracking the correct size of the world in some places. > >...

Continued in #137. Thanks for bringing this up!

> Could you also update the description of the PR with a brief description of how this PR achieves what it says in the title in case anyone looks back...

@LastTalon, I started updating the docs but I'm still not sure what to call everything. As it stands, the docs for `Component` say that it returns a `ComponentInstance`, but this...

> > but this is not true anymore. > > How so? It seems to me like it does. Well, it _can_ return a `ComponentInstance`, if we want to consider...

> This doesn't seem complicated to me. We clearly just have two types of component instance now. What else would have you it return? > > It seems to me...

Thanks for the PR. Are you able to add a test to make sure that this fixes the issue?

Thanks for the PR. Are you able to add a test to confirm that this bug is fixed?