Mike Ellis
Mike Ellis
@Thulof After a closer look, using the existing `props` prop to add the `aria-region` and `aria-live` attributes to the container won't work. `aria-live` regions are intended to exist on the...
@Thulof My apologies for the back and forth on this topic. I've unfortunately only had a few short pockets of time to think about it. I think all that can...
@afc163 Is something wrong w/ the `test-argos-ci-workflow` step? It doesn't seem like anything in this PR would have broken the workflow.
@afc163 Hiding the wrapper seems fine to me because: 1. the caret is not focusable. 2. we're relying on `aria-sort` on the `` to announce the sort direction, not the...
@li-jia-nan Is this PR good to approve and merge now?
@afc163 Is this PR good to merge?
@afc163 I thought this would have been included in the release 4 hours ago.
> The actual results are expected. @pithu Can you elaborate on your assertion that the expected behavior for parsing a date string representing a non-existent date would 1. successfully parse...
Here's another example which I've made a codesandbox for: https://codesandbox.io/s/practical-perlman-j79dks?file=/src/App.js. This example uses the "Select Time Only" example from the react-datepicker.com example exactly. Try to type "11:30 PM" (a valid...
@martijnrusschen It's even more broken now. In my codesandbox above using version 4.10.0, if you tried to type "11:30 PM", it would blow up when you hit "P". With version...