Mike Ellis

Results 104 comments of Mike Ellis

@zombieJ @MadCcc Can you please review/approve this PR?

Migration doc link in the release notes is bad. ![image](https://user-images.githubusercontent.com/39313898/202739698-e4d397f9-4d3f-4ee4-918c-c869f817d1a6.png) Seems like it should be this: https://github.com/ant-design/ant-design/blob/5.0.0/docs/react/migration-v5.en-US.md

> Because lack of knowledge and practice about a11y, sometimes we do it not in a perfect way. We are quite willing to accept PRs and code review. @afc163 I...

@kiner-tang Are you willing to fix the issue I described above that was introduced in your PR?

> Cannot find anything different, could you provide more detail for `role="alert"`? @MadCcc The difference is succinctly described in the "What is actually happening?" and "What is expected?" sections above.

@guan404ming If you're talking about creating a PR for it, that would be awesome. Thanks!

@Thulof Thanks for creating this PR! When the notification has `role="status"`, you'd also need to ensure it opens in an element with `role="region"` and `aria-live="polite"` so that screen readers will...