Hein Meling
Hein Meling
Oh, wow! That's json parsing for ya... Did this cause the parsing to fail for just the one test, or the whole file? I would suggest that we should fail...
We could consider using - [ ] [netktos/ack](https://github.com/nektos/act) to run your GitHub Actions locally 🚀
Ok. I would suggest to add a margin on the right comparable to the width introduce by the arrow margin on the left.
@JoachimTislov Jostein says we probably don't need this now that tailwind is getting closer to merge. Do you think it makes sense to keep this?
Here is a better design that avoids exposing the user to a `Manager` concept. ```go func NewConfiguration(qspec QuorumSpec, cfg gorums.NodeListOption, opts ...gorums.ManagerOption) (c *Configuration, err error) { if qspec ==...
Somewhat related... Recently, I actually thought about replacing the protobuf `per_node_arg` Gorums option with a per-call option, the same as in: ```go Multicast(ctx context.Context, d QuorumCallData, opts ...CallOption) ``` That...
When using multicast or unicast, the client receives no error signaling a graceful shutdown, i.e., to stop sending requests. That is, the Gorums runtime should recognize this error (graceful shutdown)...
The second comment is duplicate of #172.
Documents to review: - [context](https://pkg.go.dev/context) package - [errors](https://pkg.go.dev/errors) package - Blog: [Go Concurrency Patterns: Context](https://go.dev/blog/context) - Blog: [Contexts and structs](https://go.dev/blog/context-and-structs) - Blog: [Working with Errors in Go 1.13](https://go.dev/blog/go1.13-errors)
This is partially implemented; we can use the `errors.Is` now, but not sure about `errors.As`...