Hein Meling
Hein Meling
A small snag: `Submission` does not have `CourseID`, which isn't required for the logic of `updateSubmission()`, but is required by access control.
The current messages could also be converted to just one message as below: ```proto message UpdateSubmissionRequest { uint64 submissionID = 1; uint64 courseID = 2; uint32 score = 3; bool...
This is a good idea. Regarding the last point of not all "teachers" being reviewers is a crucial design decision that we should discuss. There are probably several design choices,...
Sorry I didn't look at this before. I think this design is interesting, especially from a modularity perspective. I suggest prototyping it with test cases in a separate package `internal/review`...
Deleting issues seem to require special permissions: - [Allowing people to delete issues in your organization](https://docs.github.com/en/organizations/managing-organization-settings/allowing-people-to-delete-issues-in-your-organization) - [Deleting an issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/deleting-an-issue) It is unclear if enabling these permissions via an API...
Is there an issue that should be linked to this one? I'm happy to review this if we can resolve the conflicts.
We should focus on integration instead, avoiding that users that aren’t enrolled even can sign up. We can discuss later.
@JosteinLindhom: I have been reluctant to include this one, but I want to re-evaluate this after we have merged some of the other changes. To that end, I'm wondering if...
Let's redo this PR on top of master and resolve the issue.
@JosteinLindhom Just wanted to bring your attention to this issue in case you didn't already consider Leander's requests here.