Stephen Lewis (Burrows)

Results 504 comments of Stephen Lewis (Burrows)

You could write a "[bootstrap function](https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/utils/bootstrap_utils_test.go)" - however that will require switching to a [handwritten test](https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/README.md#testing)

FWIW unless there's an extremely low quota or the resources stick around for, say, 30 days before being deleted, we find the maintainability of the `examples` to outweigh dealing with...

> The Firebase app quota per project is 36 Can we request additional quota? > What does maintaining `examples` look like? Fixing failing tests that are autogenerated from examples. >...

apologies for the delay; I'm still waiting to hear back on this.

@mdietzer-fn looking at this again, it looks like your current implementation actually excludes support for conditions by not passing `iam_conditions_request_type` - since that's an option, this actually isn't blocked by...

I see that featurestore uses a `region` field to store the location; that _should_ be irrelevant from the perspective of the entitytype resource.

Looked into this briefly - the issue is that VertexAIBasePath gets recursively replaced with something that expects a `{{region}}` field: https://github.com/hashicorp/terraform-provider-google-beta/blob/37b98fbd47237e80cedf2c9dd102fb71cd351fb5/google-beta/config.go#L451 Fixing this will likely require refactoring internals of the...

the above suggestion doesn't work because this resource also doesn't have a `location` field - the location is included as part of the parent resource field (featurestore).

Apologies for the delay. Here is a path forward: 1. use [extra_schema_entry](https://github.com/GoogleCloudPlatform/magic-modules/blob/93b1f8ad3c22a58b9bd1b9e0ac4ccf6c01d9a99b/mmv1/provider/terraform/custom_code.rb#L34-L37) to add a `region` field. Make sure that the field is marked as output-only. 2. Add a [`custom_code.encoder`](https://github.com/GoogleCloudPlatform/magic-modules/blob/93b1f8ad3c22a58b9bd1b9e0ac4ccf6c01d9a99b/mmv1/provider/terraform/custom_code.rb#L47-L55)...

It looks like you also need to make sure that `Import` sets the region field. I think that'll require a `custom_code.custom_import` override. Basically: copy the existing import code and then...