Stephen Lewis (Burrows) comments

Results 505 comments of


                                            Stephen Lewis (Burrows)

Failing test(s): google_app_engine_flexible_app_version.service_account (permadiff)

b/247158627

Failing test(s): TestAccDataflowJobWithAdditionalExperiments permadiff on google_dataflow_job.labels

This likely requires a diff suppress on the labels field for these specific labels - there may be other examples in the codebase.

data google_compute_addresses with filter

b/243811404

Only assign terraform reviewer when a pr is in a non-draft state

I think this is already the behavior - but it only works if the PR is created in draft mode (rather than being converted after the fact). I wonder if...

Dynamic compression for backend services and buckets

@cagataygurturk could you elaborate on how these resources would need to change to support this feature, and link to the relevant REST API docs? Thanks!

Dynamic compression for backend services and buckets

the new field is `compressionMode`. Looks like it should be supported at both create and update for both resources b/247161620

Allow shared object definitions to be reused in api.yaml

that makes sense - I'm down with not implementing it but in that case I'd change this ticket to cover documenting the reasoning for not covering it, so that contributors...

google_monitoring_alert_policy missing notify_on_incident_closure functionality

marking this as `upstream` to indicate that it's not supported by the API.

document resource-level properties

~The documentation for how to create a resource should also include instructions to add an update test.~ opened as a new issue: https://github.com/hashicorp/terraform-provider-google/issues/12424

document resource-level properties

also, resource-level `input` field.