Stephen Lewis (Burrows)
Stephen Lewis (Burrows)
LGTM but why is this change needed exactly? Like, what was the core change needed?
@hao-nan-li right, but why were they not getting swept properly? What did you change to make them get swept properly?
> @melinath I was confused by https://github.com/GoogleCloudPlatform/magic-modules/actions/runs/8791696170/job/24126457007?pr=10510. Thank you for your help. @damondouglas you're welcome - could you remind me how / where I helped?
oh it looks like it's still failing, maybe you were asking for help? check out the link at https://github.com/GoogleCloudPlatform/magic-modules/actions/runs/8791696170/job/24126457007?pr=10510#step:5:20 for information on release note formatting
> The note is what actually confused me. The issue is that you need to update the first comment on this PR to have a well-formatted release note. (Currently it...
I'm going to be taking over this review from Scott.
You could have done it in this PR, but that works as well.
Hi! I'm taking over this review from Scott.
yeah, if the tests require manual SQL setup then we can't automate them, unfortunately. Would you be able to share debug logs from the local manual test as confirmation? I...