magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add KMS support for the google_bigquery_connection resource

Open daanheikens opened this issue 10 months ago • 1 comments

Fixes: https://github.com/hashicorp/terraform-provider-google/issues/17955

Release Note Template for Downstream PRs (will be copied)

compute:  added the 'kms_key_name` field to the 'google_bigquery_connection` resource

daanheikens avatar Apr 30 '24 08:04 daanheikens

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Apr 30 '24 08:04 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 206 insertions(+)) google-beta provider: Diff ( 3 files changed, 206 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 162 insertions(+))

modular-magician avatar Apr 30 '24 20:04 modular-magician

Tests analytics

Total tests: 16 Passed tests: 12 Skipped tests: 3 Affected tests: 1

Click here to see the affected service packages
  • bigqueryconnection

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample

Get to know how VCR tests work

modular-magician avatar Apr 30 '24 20:04 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample[Debug log]

$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$ TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

modular-magician avatar Apr 30 '24 20:04 modular-magician

Hi! I'm taking over this review from Scott.

melinath avatar May 02 '24 22:05 melinath

Hi! I'm taking over this review from Scott.

Hi! Thanks for the review, i will see too it.

daanheikens avatar May 03 '24 05:05 daanheikens

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 178 insertions(+)) google-beta provider: Diff ( 3 files changed, 178 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 147 insertions(+))

modular-magician avatar May 07 '24 16:05 modular-magician

Tests analytics

Total tests: 16 Passed tests: 12 Skipped tests: 3 Affected tests: 1

Click here to see the affected service packages
  • bigqueryconnection

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample

Get to know how VCR tests work

modular-magician avatar May 07 '24 16:05 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

modular-magician avatar May 07 '24 16:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 156 insertions(+)) google-beta provider: Diff ( 3 files changed, 156 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 138 insertions(+))

modular-magician avatar May 08 '24 22:05 modular-magician

Tests analytics

Total tests: 16 Passed tests: 13 Skipped tests: 3 Affected tests: 0

Click here to see the affected service packages
  • bigqueryconnection
$\textcolor{green}{\textsf{All tests passed!}}$ View the [build log](https://storage.cloud.google.com/ci-vcr-logs/beta/refs/heads/auto-pr-10561/artifacts/f3c38885-0912-4b71-88af-402e9ab3165c/build-log/replaying_test.log)

modular-magician avatar May 08 '24 22:05 modular-magician