Stephen Lewis (Burrows)

Results 505 comments of Stephen Lewis (Burrows)

timed out - failures were probably related to a separate issue. rerunning /gcbrun

oh - you'll actually need to fix the merge conflict before tests can rerun @kisieland

It looks like this maybe got recorded in a previous run and is now passing in VCR? But running a manual test just to be sure: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/322368 LGTM assuming that...

one more test run - https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloud_ProviderGoogleCloudMmUpstream/328776 just to be paranoid :-) It looks like this should be fine - no (related) failures in the CI pipeline. I'm not able to...

This looks good - running new tests manually once out of paranoia: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/331626

Assigning to Riley since this has significant changes to the generation code

It looks like there are some extraneous changes to files in `mmv1/third_party/terraform/website/docs/guides/` - could you remove those? This seems reasonable otherwise. /gcbrun

> > It looks like there are some extraneous changes to files in `mmv1/third_party/terraform/website/docs/guides/` - could you remove those? This seems reasonable otherwise. /gcbrun > > I do drive by...