GoogleCloudPlatform
Add `mesh_certificates` field to `google_container_cluster` resource
Fixes: https://github.com/hashicorp/terraform-provider-google/issues/9973
If this PR is for Terraform, I acknowledge that I have:
- [X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
- [X] Generated Terraform, and ran
make testandmake lintto ensure it passes unit and linter tests. - [X] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
- [X] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
- [X] Read the Release Notes Guide before writing my release note below.
Release Note Template for Downstream PRs (will be copied)
container: added `mesh_certificates` field to `google_container_cluster` resource
Hello! I am a robot who works on Magic Modules PRs.
I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.
Thanks for your contribution! A human will be with you soon.
@melinath, please review this PR or find an appropriate assignee.
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 3 files changed, 16 insertions(+), 17 deletions(-)) Terraform Beta: Diff ( 7 files changed, 123 insertions(+), 26 deletions(-))
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 3 files changed, 16 insertions(+), 17 deletions(-)) Terraform Beta: Diff ( 5 files changed, 122 insertions(+), 21 deletions(-))
This is ready.
It was good that it got delayed as Google changed the field from workload_certificates to mesh_certificates when it got promoted to v1.
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 5 files changed, 117 insertions(+), 17 deletions(-)) Terraform Beta: Diff ( 5 files changed, 117 insertions(+), 17 deletions(-)) TF Validator: Diff ( 5 files changed, 117 insertions(+), 17 deletions(-))
It looks like there are some extraneous changes to files in mmv1/third_party/terraform/website/docs/guides/ - could you remove those? This seems reasonable otherwise. /gcbrun
It looks like there are some extraneous changes to files in
mmv1/third_party/terraform/website/docs/guides/- could you remove those? This seems reasonable otherwise. /gcbrun
I do drive by doc updates on issues I come across.
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 5 files changed, 117 insertions(+), 17 deletions(-)) Terraform Beta: Diff ( 5 files changed, 117 insertions(+), 17 deletions(-)) TF Validator: Diff ( 5 files changed, 117 insertions(+), 17 deletions(-))
It looks like there are some extraneous changes to files in
mmv1/third_party/terraform/website/docs/guides/- could you remove those? This seems reasonable otherwise. /gcbrunI do drive by doc updates on issues I come across.
Gotcha. In general, our best practice for this repo is to keep PRs small and focused on a single logical grouping of changes, since that makes it easier to review PRs, easier to understand the commits after the fact, and prevents changes that are unrelated from getting blocked by each other. For example, the docs improvements to mmv1/third_party/terraform/website/docs/guides/ have been blocked by the rest of this PR - they could've been merged a long time ago (assuming they pass review.)
Please move those changes to a separate PR, and try to create separate PRs for unrelated docs improvements in the future. Thanks!
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 5 files changed, 117 insertions(+), 17 deletions(-)) Terraform Beta: Diff ( 5 files changed, 117 insertions(+), 17 deletions(-)) TF Validator: Diff ( 5 files changed, 117 insertions(+), 17 deletions(-))
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 3 files changed, 108 insertions(+)) Terraform Beta: Diff ( 3 files changed, 108 insertions(+)) TF Validator: Diff ( 3 files changed, 108 insertions(+))
Started a test run for just the new test: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloud_ProviderGoogleCloudMmUpstream/257220
Also, /gcbrun
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 3 files changed, 108 insertions(+)) Terraform Beta: Diff ( 3 files changed, 108 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 3 files changed, 108 insertions(+)) Terraform Beta: Diff ( 3 files changed, 108 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudbuildWorkerPool_basic|TestAccContainerCluster_withMeshCertificates|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=257867