Able to show outiline in readonly mode

[vinicius73]

• Resolves: #2904
• Target version: master

Readonly

https://user-images.githubusercontent.com/1561347/190261995-20c63bc2-5c7b-49b3-a6e6-5cc34a480f42.mp4

Public

https://user-images.githubusercontent.com/1561347/190262053-cd9f71de-af29-4735-98a9-4db1ded0d385.mp4

[mejo-]

Thanks a lot for looking into this @vinicius73 :heart:

Unfortunately using the menubar space in read-only mode conflicts with Collectives, where we already use this space for Collectives-specific content (last changed user and timestamp, in future also things like count of backlinks and attachments). Sorry, I don't have a quick solution for this. Maybe we should discuss it in our next team call?

[vinicius73]

Thanks a lot for looking into this @vinicius73 :heart:

Unfortunately using the menubar space in read-only mode conflicts with Collectives, where we already use this space for Collectives-specific content (last changed user and timestamp, in future also things like count of backlinks and attachments). Sorry, I don't have a quick solution for this. Maybe we should discuss it in our next team call?

What do you think about make able to inject a slot that space and expose some editor methods?

So that way you will be able to not only inject more options also access internal editor methods in a safe way

[vinicius73]

@jancborchardt what do you think about this?

[mejo-]

What do you think about make able to inject a slot that space and expose some editor methods?

So that way you will be able to not only inject more options also access internal editor methods in a safe way

That would be the way to go indeed :blush:

[jancborchardt]

@vinicius73 it's better if the x is on the right if the text, so that the text is left-aligned with the headings below. :) Just not all the way over away from the text.

[juliusknorr]

/backport to stable25

[blizzz]

master is 26

[mejo-]

@vinicius73 could you take a quick look into rebasing the PR on latest master? Seems like something went wrong and unrelated commits got pulled in :wink:

[vinicius73]

@mejo- I've rewritten the all PR, check if you can please

[mejo-]

Nice, thanks a lot @vinicius73. Works like expected. I removed the top: 104px as discussed here. It doesn't solve the problem for Collectives yet, but at least it doesn't break Collectives any longer - and it adds outline support for read-only Text shares, which is great :heart_eyes:

[mejo-]

/compile

[backportbot-nextcloud[bot]]

The backport to stable25 failed. Please do this backport manually.

[mejo-]

/backport 103d8ef26df9ec6c86098eecbf16304f08248f7d,7d9a18b15c56608fa38492ec9d7f877130922488 to stable25