Graeme Yeates

Results 100 comments of Graeme Yeates

Splice was added in https://github.com/jashkenas/backbone/pull/3663. I'll defer to @jridgewell on this one. If this does get in, I'd rather remove the internal `splice` function all togehter

I suspect the only viable way to do this without duplicating the logic which handles whether to provide a model or attributes is to chain by default

I'm sympathetic to this changeset and think a movement like this may be a good way to move backbone forward (along with @jmeas' proposed router changes) in v2. So a...

Also, there is significant overlap with https://github.com/jashkenas/backbone/pull/3651

I'm fine with this but it may be a minor breaking change. I'd consider it a bug fix personally though

I do think `_.sortedIndex` should be delegated to for the same cases as `sort` delegates to `sortBy`, in order to prevent possible inconsistencies between this and `sort` (https://github.com/jashkenas/underscore/issues/1768)

`getMin` and `getMax` are trivially interchangeable. Just increment by 1 once and then until `x[i] !== x[i+1]` This function has too many unnecessary options and params. I'd ditch those options...

1) You could easily optimize for the duplicate case but I don't think thats necessary. 2) code redundancy, simplicity and future-compatibility with `_.sortBy`

1) Read the underscore issue I linked earlier. 2) this is a sorted index I don't really see the rational of needing a right sorted index at all. The sort...

@joshbambrick that's not 1.7 but the master working branch.