Medha Bhardwaj
Medha Bhardwaj
> Slightly deviating from my previous response in [#4490 (comment)](https://github.com/pybamm-team/PyBaMM/pull/4490#issuecomment-2975814188) here: > > This PR is going to be merged soon enough as it is nearing its completion, but it...
I have implemented the necessary changes for handling 0D variables. Once this is confirmed to be working correctly, I plan to work on handling 1D and 2D variables. Additionally, I...
Hello @agriyakhetarpal could please give a review on this? :)
> Also, the implementation would be simpler if you just set `self.x_axis`, `self.x_min` and `self.x_max` once and used those everywhere, instead of having the if/else for time and discharge capacity...
> I think the change looks good, could you please add a test or two? I expect the coverage to go down as you have a few branches in the...
For now I have added tests for the function , let me know if any other changes are to be made > Do I also have to make similar changes...
I have made the suggested changes, if anyone could review this one :)
I have added tests for the missing lines, are there any other improvements I need to make ?
I would also like to work on the second issue, which involves creating a `static_plot` function. Could you please provide a more detailed explanation of this issue to help me...
I have implemented better option checking by creating an `ensure_tuple` method. This method automatically converts any string-based options into tuples, ensuring consistent handling of options.