minhaz

Results 171 comments of minhaz

This is great. I'll look into this one. Is there a way to do a benchmark test on some small sample to have measurable perf impact on large / small...

Wouldn't we want to test each overload with unit test and validate different scenarios for each combinations?

@ckarande There are a lot of options - You can use labels, or put up a comment suggesting the same. For example check this todo: https://todofy.org/r/mebjas/NodeGoat/master/169300 - Also if there...

Does the app have camera permissions?

@dennmtr That makes sense, the reason that it's not so is I don't know how to get exactly the front and back camera in single query, or how to determine...

I can possibly exposure arguments to `getCameras` so you can request camera of choice and build your user interface on top of it. You can call it like ```js Html5Qrcode.getCameras({...

@pradeepngupta @nivthetool @dennmtr @max2ti @peterA1 I had a few questions to understand this better. The original feature request was raised to add the support for `Html5Qrcode` class. And as I...

**Update** On further digging I realised that the `navigator.mediaDevices.enumerateDevices()` doesn't support `constraints`. So the support shall be added to `Html5Qrcode#start()` method. Earlier it could be called only with exact cameraId...

Updated the support in `Html5Qrcode#start()` - Released as `v1.2.1`: https://github.com/mebjas/html5-qrcode/releases/tag/V1.2.1 - npm: https://www.npmjs.com/package/html5-qrcode