Dave Brosius comments

Results 76 comments of


                                            Dave Brosius

BAD_PRACTICE when throwing sub classes of java.lang.Error

I agree catching error is wrong. Not sure about the throwing part. I'm OK with that in some cases

Detect improper args for SLF4J Logger::error

so you are doing LOGGER.error("Lookie an error->{}", e); and it is mapping to the second method. yeah, makes sense, i can do that. altho it's kind of odd that you...

Detect improper args for SLF4J Logger::error

ah, i get it, it's not that you wanted to pass the exception to the marker, it's that you forgot to add the parm, and so the method resolution was...

Detect improper args for SLF4J Logger::error

thanks for the report. See how that works for you. Feel free to reopen if need be.

Detect improper args for SLF4J Logger::error

I'm not sure what you want me to do here. You're saying if the last parameter is an exception, you want to make sure that the call is to a...

SEO proposes unsafe optimizations

thanks for the report, I agree it is a bug in fb, and i'll look to address. But i'd also say that code is poorly written. it would be better...

SEO proposes unsafe optimizations

haven't forgotten this, i just haven't thought up an reasonable way to do this yet.

Detector suggestion: Expecting Error in unit tests

so if you expect Error, then have any kind of Assert.xxx code, report that?

PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS not applied to static initializer

the suppression of bugs is a findbugs/spotbugs thing, so really the fact that the suppression didn't work is a findbugs/spotbugs bug.

False positive AI_ANNOTATION_ISSUES_NEEDS_NULLABLE ?

Thanks for the report. Is there any difference with 7.4.2? Does getProperty(key) possibly return nulls? {not that that should matter}