Maddy Miller
Maddy Miller
I've done some testing of this PR, and it definitely seems vastly better than the existing behaviour, thank you for this! I'm approving it based on code changes & my...
It's common amongst tests, usually for test data of complex types. I'm not super happy about it, but in my experience this is a fairly common pattern across tests in...
Comparing exactness does feel like it'd catch a majority of cases at least so that makes sense to me. Only case I'm not sure it'd match is the assignability case...
> Hey @me4502, I'm implementing your desired changes in #11789. I noticed that the example cases from your first comment are incorrect. `alsoRequired` should be of type `string` and not...
> `[01:24:10 ERROR]: Could not pass event EntityChangeBlockEvent to WorldGuard v7.0.14+2339-43997ec java.lang.NullPointerException: Cannot invoke "org.bukkit.World.getBlockAt(org.bukkit.Location)" because the return value of "org.bukkit.Location.getWorld()" is null at org.bukkit.Location.getBlock(Location.java:131) ~[paper-api-1.21.8-R0.1-SNAPSHOT.jar:?] at worldguard-bukkit-7.0.14-dist (3).jar/com.sk89q.worldguard.bukkit.cause.Cause$Builder.addAll(Cause.java:345) ~[worldguard-bukkit-7.0.14-dist...
To clarify, are you asking for the ability to translate text? Translations are pulled in automatically from our community translation project, https://crowdin.com/project/craftbook - If you're wanting the text translated to...
This might just require jukeboxes to be removed as a possible pipe target tbh. I had similar issues with API inconsistencies with the redstone jukebox mechanic using the Spigot APIs...
A PR would be appreciated. Although it seems like it's meant to be only cleared if a container is found, Pipes in general don't modify the "starting" container until the...
Thanks for this- I haven't had a chance to fully look over the code, but it seems to vaguely resemble my plans for CraftBook 5's pipes- (computing pipes and then...
It's less about specific divergences, and moreso that this is a very large-scale rewrite on a legacy branch of a plugin that's in maintenance mode, and mostly kept around for...