Matthieu Dubet comments

Results 6 comments of


                                            Matthieu Dubet

Use StyleColor object instead of Color in WebCore

I've revamped the PR, it now contains only the refactoring from Color to StyleColor. It should not have any behavioural change ; except a bug fix in the SVG currentColor...

[css-cascade] [css-nesting] Figure out whether we're fine with "shifting up" bare declarations after rules

FWIW we (WebKit) were also very surprised by our poll results (it actually changed over the weekend, the first days were Option 2 winning 70/30). Disallowing declarations after rules seems...

Removing redudant code path checking on FontCascade::displayListForTextRun

(typo in the commit message `parital`)

Web Inspector: Improved Contrast between text, background, and borders in `prefers-contrast: more`

(Nitpick: we should remove the "amend changes" and "combined changes" lines from the commit message)

[WTF] WTF_ALWAYS_LOG

Is the `WITH_STREAM` really helpful ?

CSSPageRule to inherit from CSSGroupingRule

Seems reasonable. Note that this will be the first example of a class inheriting`CSSGroupingRule` which doesn't accept a style rule as a child it seems ?