Matt Solomon
Matt Solomon
Really great writeup! Based on my understanding from the writeup, the Governor-initiated Checkpoints (GIC) feels like the clear choice. Overriding the `propose` function to also call `aToken.snapshotReserves()` is a very...
Hmm interesting, so the spec would include when certain errors/events are expected to be thrown/emitted? Do you have a sample UX in mind for this? I've been thinking a bit...
Huh interesting, I believe @0xGorilla and I saw issues with pretty much that exact snippet, but yea this test suite is where I was originally seeing the issue. You can...
If you have this: ```solidity contract A { error NotValid(); // contract A specific code here... } contract B { error NotValid(); // contract A specific code here... } ```...
One thought is that there's probably a few create3 implementations. I'm working with @pcaversaccio to make the one in https://github.com/pcaversaccio/createx a canonical one—I'm biased of course, but hopefully within ~2...
I don't have a great pulse on the state of the book currently—@gakonst maybe worth putting out a tweet to get feedback on where docs are lacking and what tutorials...
Closed by #843? cc @mattsse
No anvil/testnet required, basically just trying to convey that you can run your deploy script in the `setUp` portion of your tests. So say you have `Deploy.s.sol` where the public...
> I still think it would be worth it to add an explicit note about what it means to test deployment scripts in practice - I can open a PR...
That error means your script has ` vm.startBroadcast` call but no corresponding `vm.stopBroadcast` call before a `vm.prank` in a test. (Or a floating `vm.broadcast` that wasn't used). Perhaps you are...