maxime

Results 35 comments of maxime

Well we are not using vue, afaik it should be possible to make a skeleton in pure css. let’s start by adding a loading icon and we’ll replace by a...

It makes sense, then maybe we should add some kind of regex in the settings when disabling inner links also, so people can type in something like *.github.com or just...

hum no, this is manifest related. Currently the extension has 2 options to disable it : - The page setting : which disables Survol completely on the page, when disabled...

The link you sent earlier explains how to enable / disable the extension via the manifest.json file, which is not what we want, we want to enable / disable the...

I think all the changes should be implemented in this PR as otherwise everything would break

I'm not sure if you're done with this, but we need to adapt the way we disable the extension in [core.js - master - 230](https://github.com/mdolr/survol/blob/edba433953334d5d7c25d8f77d14c96ffc90f292/js/core.js#L230) in order to make sure...

Yes but right now without modifying anything if you block "github.com" it will only block the extension on github.com and not on every subdomains because you've added subdomains in you...

I guess we could modify the regex to to add an exception for a list of selected subdomains

I'm not a regex pro but something like this I guess (assuming gist is blocked) `^((gist|cdn).*).github.com|github.com$` In this example gist.github.com, github.com and cdn.github.com are whitelisted, everything else is blocked, You...