Mark Otto
Mark Otto
https://codepen.io/emdeoh/pen/WNyeNeQ works for me
Oh my bad! Reopening.
@twbs/js-review Any thoughts?
Agreed this is inconsistent. The demo markup in our docs breaks though with adding `margin-left: auto` a la close buttons elsewhere. I'll need to work out a fix there, too....
> I'm not sure what changes would be required That's the primary concern for us, as @GeoSot mentions. We don't know how much work it'd be to replace this, and...
@romaricpascal So sorry for dropping the ball here. I'd like to get this merged in so we can write some additional tests—any chance you can bring it up to speed...
Thank you so much @romaricpascal! Happy holidays to you and your's :D.
Closing as won't fix / stale for now.
In general I lowercase-dash everything—classes, names, ids, etc. I don't label it anyone thing or another and mostly optimize for my own experience with it. Like double-clicking parts of a...
Finally circled around to this and while I'm sure the increased target area is helpful, it's odd to see a massive focus ring around the thumb. Looks a little broken...