Michael D. Norman

Results 23 comments of Michael D. Norman

> I guess my question @frangio and @GVTopCoder is even if this not available for a long time would it be possible that the openzeppelin official version uses the same...

Even if solhint only works at file-level, it can see the imports, and if it looks at the structure of the contract, it can parse out whether it's a variable...

To answer your question about the rule config, I probably wouldn't whitelist the classes. Instead, I would just do what I'm doing now, which is to use `// solhint-disable-next-line mark-callable-contracts`

I see what you mean regarding the filename not matching the contract name. I created the struct bug here: https://github.com/protofire/solhint/issues/198 Is the rule currently just looking for function calls on...

FYI, I'm using this code locally and it seems to be working well with my property resolvers 👍

I've created a test that demonstrates this at https://github.com/mdnorman/KGraphQL/commit/d97189dee3b84099e30ddcb0b1229987c3471466 This query doesn't work, even though it should: ``` { hero { id ...heroName } } fragment heroName on Hero {...

Submitted a PR: https://github.com/pgutkowski/KGraphQL/pull/51/files

Though that appears true, if you decompose the base contracts enough, this isn't that big of a problem. You can leave gaps in the structs as needed. However, if you...

I've created a PR that adds source context to the uglifier: https://github.com/lautis/uglifier/pull/159