mdmathias

Results 18 comments of mdmathias

Hi @peterfriese thanks for the PR! It looks like it fails some checks during `pod lib lint` on macOS 10.15. I was thinking that we'd address #91 by updating the...

You're correct - changing the block parameter name to `completion` would break the API and require a major version release. Does adding the `swift_async_name` attribute not break the API? I...

Another consideration is that we are due to have a major release coming up soon anyway. Perhaps it's okay to change this API? What do you think @petea?

I did a little informal test and it looks like adding the `swift_async_name` attribute just adds an `async` method, but leaves the existing API unchanged. Without the attribute: With attribute:

Hi @peterkos; thanks for the comment and the feedback. I agree that the sample app we merged in #63 does not resolve the issue at stake here. We meant to...

Surfaced during discussion on https://github.com/google/GoogleSignIn-iOS/pull/230.

@hupendraaplite please see my [comment here](https://github.com/openid/AppAuth-iOS/issues/78#issuecomment-1684212245) on a related question. Unfortunately, you cannot modify this alert.

I'm closing this to de-clutter our issue backlog since this doesn't appear to be a bug.

Closing on behalf of @ywsang per https://github.com/openid/AppAuth-iOS/issues/402#issuecomment-2021684293.