Matt Layher
Matt Layher
It seems you're correct! A length check should be added to each of Bytes, Do, and String. Want to send a PR?
Internal improvements are always welcome, as long as they don't dramatically impact the readability of the code! I'd be happy to take a look at what you have in mind.
I've committed a fix for the length overflow issue, but will retitle this for the performance improvement issue.
I'd like to at some point, but for these packages in particular, I'm nowhere near ready to guarantee stability. - ovs: grew organically, mixes up parts of OVSDB/OpenFlow, bloated API...
Thinking about this more, I think a pre-1.0.0 tag could be fine. Doing some research on Twitter now.
I wasn't even aware of this option until now. To clarify, can you not accomplish the same thing by pushing/popping VLANs with flows?
I think I would prefer to add this alongside the other "ovs-vsctl set" methods in this structure: https://github.com/digitalocean/go-openvswitch/blob/master/ovs/vswitch.go#L182 for consistency, rather than adding more parameters to AddPort immediately. PRs are...
Yep, seems reasonable to me. I'm happy as long as it compiles on all platforms, even if every method returns an error when not running on Linux.
Since we are providing packages and not an application, we don't explicit vendor our dependencies. Importing it without vendoring is fine, especially because both repositories belong to DigitalOcean.
Sounds good. Apologies for all the comments; just trying to keep things consistent throughout the repo where possible.