Michael Dietze

Results 128 comments of Michael Dietze

AFAIK this has not been addressed, as there are clearly many uses of `trait.lookup` still in the code ``` grep -ir "trait.lookup" . Binary file ./.git/index matches ./modules/priors/R/plots.R: scale_x_continuous(limits =...

@DongchenZ not only should all calls to nc_open be paired with a nc_close, but it is often good to wrap a nc_close in an on.exit() call right after the nc_open....

That also won't work for shorter runs. Don't forget that we've now got 16 day SIPNET forecasts running daily at Willow Creek

If the issue is the difference between runk and r136 (and moving forward) then I'm fine with breaking backward compatibility with runk, dropping it from the VM, and labeling it...

Sounds like we've concluded that years start at 0. Are there other things to resolve here? (other than some code fixes and tests to make sure ever met2CF, met2model, and...

I'm not sure what qsub_build.sh was for (I can't find anything else calling it or anything in the documentation), but the current script for installing dependencies is docker/depends/pecan.depends.R

@bcow at today's PEcAn meeting we decided to close this PR since no one has worked on this for 5 years and it's not anything anyone is planning on working...

Could you provide a more informative PR title and description?

@Qianyuxuan there's a bunch of errors coming up in the build that suggest that you're missing namespaces on functions ``` check base/workflow 0 warnings found in base/workflow. 1 notes found...

``` check modules/data.land 2 warnings found in modules/data.land. 2 notes found in modules/data.land. Error: Please fix these and resubmit. R check of modules/data.land returned new problems: checking Rd \usage sections...