Matt Diephouse

Results 139 comments of Matt Diephouse

> Having info.plist key set but having no features related to photo library is weird. I agree. I suggest filing a radar.

This looks like the `UIImageView` has a reference to an `unowned` or otherwise invalid object.

I don't think it's worth the time to try to build something like this for Objective-C—especially since this concept can't be implemented cleanly. IMO you're better off spending that time...

I'm sorry, but I don't understand. Can you provide more detail?

I am definitely not a swizzling expert. I think fixing it is great if we can, but we should be confident that we haven't broken anything.

ReactiveViewModel was built with the Objective-C RAC APIs, which are unchanged since RAC 2. So upgrading to a newer version is a very mixed bag—it lets you use the Swift...

That looks correct to me. Are you sure the disposable is what's canceling the task? Does `doVeryLongRunningTaskForItem:withCompletion:` handle concurrent requests properly?

It should work as a framework, but I'm not a cocoa pods expert.

Thanks for the pull request! :sparkles: The change looks good to me, but I'd like to add some comments that explain this. Unfortunately, I think most people will be unfamiliar...