ReactiveObjC icon indicating copy to clipboard operation
ReactiveObjC copied to clipboard

Published 20 hours ago • verified publisher icon ReactiveCocoa

Remove UIImagePickerController+RACSignalSupport to fix AppStore upload NSPhotoLibraryUsageDescription key issue

Open denniszxxc opened this issue 7 years ago • 3 comments

Previous discussion: https://github.com/ReactiveCocoa/ReactiveCocoa/issues/3190

I don't think adding a dummy key was a good solution. Having info.plist key set but having no features related to photo library is weird.

Should we remove this two files UIImagePickerController+RACSignalSupport.h & UIImagePickerController+RACSignalSupport.m ?

denniszxxc avatar Dec 16 '16 03:12 denniszxxc

Having info.plist key set but having no features related to photo library is weird.

I agree. I suggest filing a radar.

mdiep avatar Dec 16 '16 05:12 mdiep

I see it as a breaking change :) I would suggest to extract UIImagePicker-related code to a cocoapods subspec and include it by default, so we can keep this functionality if needed, and still can opt it out.

Not sure about Carthage, can anybody suggest how to conditionally deliver UIImagePicker-related code?

ReDetection avatar Jan 16 '17 05:01 ReDetection

Hi,

I'm facing this issue too. Could you guys release a new version with this PR included ?

BR,

vitorhugomagalhaes avatar Jan 20 '17 16:01 vitorhugomagalhaes