Michael Holloway
Michael Holloway
For the currently deployed Wikimedia REST API mobile-sections endpoint, moving the initial paragraph of an article up top, even above hatnotes, is actually the intended behavior. This was driven by...
@kelson42 Yes, that's correct. Hatnotes will be broken out like this: https://gist.github.com/mdholloway/5010f7c4f737cd3262288563d643240a#file-resp-txt-L27-L29
Actually, my mistake, there's also code setting/calling `Err.metrics` in the `maki`, `server`, and `snapshot` packages.
Actually probably cleaner still to set the statsd stat name in the constructor itself. (Also, taking a step back, I'm pretty sure no one is actually looking at these stats,...
Not for merging yet... Notes to self: - [x] Restore bunyan-prettystream - [x] Figure out why this breaks tileratorui (The latter was because of added (and now removed) CSP rules,...
The advantages of changing to eslint-config-node-services, as I see them, are (1) improving consistency with other node services maintained in whole or in part by WMF, and (2) making it...
OK, this is now ready for review. The Kartotherian ESLint config is restored and the remaining changes are substantive.
(Side note: I agree that the template update process is clumsy. To the extent there are common utilities that need updating from time to time, those should probably go into...
@nyurik Sorry, was the change you requested to restore the Kartotherian ESLint config, or not to do a template-upgrade commit at all? There is a bit more work I could...
Back to kartotherian eslint config, backed out the Grunt removal, added .eslintignore for files from the template.