Matt Gilene

Results 20 comments of Matt Gilene

Seems like there was an initial go at getting this working recently. But the documented approach doesn't seem to work for me. Using the above example my code would be...

Correct me if I'm wrong but isn't the real key missing part for all of this the serializers/deserializers/validators for all the Mongo/Bson datatypes in Pydantic. If Pydantic added support for...

@art049 Hey, this looks very promising as an all in one solution the problems discussed in this thread. Would be great to get some buy in from the major players...

> I'm having troubles with this fragment here: > > https://github.com/tiangolo/fastapi/blob/fdb6c9ccc504f90afd0fbcec53f3ea0bfebc261a/fastapi/encoders.py#L43-L46 > > In my case, I'm attempting to temporarily apply encoding logic for a pydantic object but I very...

Note, I am new to contributing to this project so looking for input on this PR and if you see issues with code format/style/etc. please let me know and I...

I believe you're right. I missed this piece during my initial read through. I've updated it so that it's only added if the connection is made over TLS.

> Interesting stuff, thanks. > > Thoughts on stuff retrospectively, that might or might not be valuable to mention... > > * It probably would have made sense for the...

> @mdgilene would you mind rebasing it? It's already released by asgiref, so I think we can start reviewing it. > > @tomchristie @euri10 I'd like this to be reviewed...

Very interested in seeing any progress on this proposal. Adding this to the spec would seem to provide one of the final missing pieces of information about a connection to...

I'd be happy to look at this again as I've been out of the loop on this for a while. But from what it seems like is that we are...