Martin Bayly

modify componentWillReceiveProps to check with mask to see if mask va…

5

…lue would be updated by new props rather than just checking to see if props have changes. Fixes issue where if a change is rejected by the client onChange handler,...

added new method hasValueChanged to check to see if a new value would…

2

… change the output value of the mask This is a new method that will be used by react-maskedinput to determine if new props will change the mask value. It...

Question: Any reason why blank placeholderChar not supported?

1

I was trying to use the react-maskedinput library to handle entering percentages with a mask like: '111%'. Ideally I'd like to not have any placeholderChar because 9% and 99% would...

Question: File task_1_answer_id_ordering.npy referenced by the Eedi preparation script does not exist

6

https://github.com/rschmucker/Large-Scale-Knowledge-Tracing/blob/master/src/preparation/datasets/eedi.py#L195 This file `task_1_answer_id_ordering.npy` does not exist in the dataset. Maybe it was created out of band? From the code it looks like provides some kind of indexing to `AnswerId`...

Question: Should default sw-precache skipWaiting be false NOT true?

1

### Description When using the default service worker configuration, if you change multiple pages in your app e.g. view1.html and view2.html and then reload the app following a build, the...