Michael Dellanoce

Results 27 comments of Michael Dellanoce

this _might_ have an impact on performance when things do make it to the addList though, since the node order is reversed, and addList is traversed from the tail node...

Just had this happen on another customer's site, so seems somewhat common for Angular apps.

zone.js strikes again... added a similar commit for addEventListener. This one wasn't a performance issue, but the passive mousemove listener added by rrweb forces _all_ mousemove listeners added through zone.js...

@Juice10 I updated rrweb-snapshot's setTimeout calls. Those seem unlikely to lead to endless looping like what I've seen with hookSetter, but I guess it doesn't hurt. > This PR doesn't...

a test failed, but i'm not sure why...

added a similar fix for requestAnimationFrame in ProcessedNodeManager. If #1328 ever merges that commit can be dropped

@Mark-Fenng @Juice10 thanks for the feedback, totally understand the performance concerns. I think the maskAllText suggestion will work, and I have a few other ideas. I'll see what I can...

@YunFeng0817 @Juice10 sorry for the delay, but I added 3 commits to address performance: 1. if maskAllText is true, and unmasking either is not configured (best case) or fails to...

@Juice10 I added 2 new benchmarks for masking and unmasking. Here are the results from master: ![image](https://user-images.githubusercontent.com/541814/230945485-610ad2ad-4111-4dd5-8960-10ccc8290cd3.png) ![image](https://user-images.githubusercontent.com/541814/230945514-e0c783d2-ae3e-4add-afa7-386ded3e0a91.png) ![image](https://user-images.githubusercontent.com/541814/230945563-fefc1a9b-8fc7-43ca-bbbd-559335030cd5.png) ![image](https://user-images.githubusercontent.com/541814/230945597-8f470420-008c-45e3-acba-c3100793a773.png) Note: the unmasking test on master is effectively the same...

@Juice10 ready for another look, i think