Matthew Eernisse

Results 134 comments of Matthew Eernisse

Looks like you need to upgrade either to 1.0.0, or to 2.0.x. There are passing tests for this for both versions.

It is fixed in 1.0.0. Just upgrade to that version in your package.json. But 1.x is no longer being maintained. The current release is 2.x, which is here: https://github.com/mde/ejs

I'd be happy to merge this PR or one like it if it doesn't break existing tests. I'm taking a look at it now, buit the merge might go faster...

@jasper-lyons I'm probably missing something, but I'm not clear on what that block of code with the switch is for in this last commit. I made a simpler change yesterday...

@jasper-lyons Ah, I was looking at the changes to the built file. Looks like your change is pretty much what I implemented in master. Can you verify if it works...

@jasper-lyons, I am doing a version 2.0 (using my preexisting EJS implementation from Geddy and previous) that handles includes as a simple function call at runtime: https://github.com/mde/ejs Could you take...

@parkr I'm ostensibly maintaining this, although I haven't had a chance to do much with it yet. I'll make sure I can publish to NPM and try to get a...

Pong. :) It's the holidays! I'm looking at this PR: https://github.com/tj/ejs/pull/156 and trying to get tests passing before I try to push.

@parkr and @silverbucket I am putting together a v2.0 here: https://github.com/mde/ejs It uses a preexisting implementation I bundled with Geddy, and I believe I've got feature parity (except for filters,...

@parkr Good call: https://github.com/mde/ejs/blob/master/CHANGELOG.md There are backward-compat shims for the change to separate data/options, and for the `include` function. No changes to existing code should be necessary for those. The...