Michael Davidson

Results 12 comments of Michael Davidson

Given the consistent way of how components are stacked across apps I would like to see default z-indexes for all components. I don't have a preference where or how it...

@lennonmarley Have you customised the 'spree/checkout/_payment' partial or the localisation files? You could have a stray quotation mark (")?

Hi @damianlegawiec , I believe you are currently in the process of merging this extension into Spree master. Would you like me submit a PR on the Spree repo with...

@damianlegawiec This issue can be closed, as was resolved by PR #125

I had the same issue. Was able to resolve by changing the first few lines of _header.pdf.prawn to: ``` rel_path = Rails.application.assets_manifest.assets[Spree::PrintInvoice::Config[:logo_path]] im = Rails.root.join("public","assets",rel_path) if im && File.exist?(im) pdf.image...

@aman29april Agree. Have just had some time to work on a better solution which works in production and development. What about the below as an approach? Working for me in...

Thanks @jsilland , your notes were very helpful. :+1:

Thanks for the review @letelete . I have updated to address your feedback if you would like to take another look :+1:

Just to add to the previous responses. If others are running into the same problem with label obscuring the text I was able to resolve the issue with the label...