Michael Cordell

Results 8 comments of Michael Cordell

Thats a good point, it should inherit from StandardError. I'd accept a PR or I can make the change when I get around to it

Hi bharatsoni, I'm not sure if it is a Rails 4 bug per se, I have my fork fine in a Rails 4 app. Check out my fork at: [https://github.com/mcordell/noaa](https://github.com/mcordell/noaa)...

Hi @vanburg I have a preliminary implementation of this feature in the branch `refactor-responses` if you would like to check it out and give me feedback, that would be great....

Thanks for bringing this to my attention and the detailed bug report, I will look into this this week and report back.

Update: I've reproduced the issue in the demo app and am working on a fix.

@vanburg can you check the attached PR. See the note in the PR about the two validation calls.

Hi @evserykh I have a preliminary implementation of this feature in the branch `refactor-responses` if you would like to check it out and give me feedback, that would be great....

There isn't anything intentionally updating sign_in_count https://github.com/mcordell/grape_devise_token_auth/blob/c5b1ead8dbad1dc9fa2a2e7c9346f167e1d9fb1f/lib/grape_devise_token_auth/auth_helpers.rb#L10-L16