Matteo Collina comments

Results 3331 comments of


                                            Matteo Collina

Pretty print method with a common prefix option doesn't have much sense

go for it!

Bug `-` parameter separator logic

In https://github.com/delvedor/find-my-way/pull/27, this feature was actually coded with - as a separator, so it's working as expected. We can potentially change this in a semver-major (one is due soon), but...

Bug `-` parameter separator logic

That would work.

Unexpected behavior on double slash in path

This is expected! A new option would be ok.

Unexpected behavior on double slash in path

https://github.com/delvedor/find-my-way/pull/50 would be a good one.

Unexpected behavior on double slash in path

You are right, closing.

Static routes optimization

What do you mean by part? If you want to do bring this to the next level of perf we might want to generate a full function and get rid...

Static routes optimization

> By part, I mean usage percentage. What percentage of static routes have in relation to all routes? Maybe static paths are a rare case and most people use parametric...

Static routes optimization

I agree with you with the exception of first level paths, /, /news, /about, /shop, etc.

Optionally breaking the circuit without having to wait for the route handler to finish

This looks like a good feature to add! However it might be better implemented on top of AbortController. Could you take a look at that API and see how it...