Matteo Collina

I'm 👎 . It should error on the second time (in the callback, reject in the promise). I probably added that part in a haste. That whole logic could be...

go ahead and create a PR! Il giorno gio 5 apr 2018 alle 22:19 Dustin Deus ha scritto: > Do you working on this or can I create a PR?...

This should work: 1. if we are booting, then wait for the boot to finish (call `.ready()`). 2. if we are not loading at all, do not call `ready()`, but...

Note that avvio does not anything about prefixes, those are fastify thing. Other than that, *go for it*.

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.

Would you like to send a Pull Request to address this issue? Remember to add unit tests.

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.

I think you just need to cache the proxy, not the nest app.

I would recommend to use ESM and move the two await to be top-level awaits and just use the proxy as your handler.

I would say that "start then ready" is definitely incorrect and _not_ the intention. I'm happy to fix it in avvio `master`. Overall, the implementation of that behavior is wrong...