Mary McGrath

Results 24 comments of Mary McGrath

Yes, I think these are both good improvements. Lets make sure the README/docs calls out that we do this sharing (cool optimization!) and that because of that when debugging only...

Perhaps a `VegaRecipes` repo would make sense? On Mon, Feb 3, 2020 at 7:50 PM David Anthoff wrote: > This > > suggests that we can probably avoid the whole...

@tanmaykm @aviks would it be possible to add this example to the README? This would be really helpful

> Hmmmm, I don't know that I love this use of `Missing` when a field/value is missing (I know, I know, pun not intended). What about the approach of still...

I don't think of `show` as having the sort of contract as `repr` in Python where that really ought to be able to be evaluated and return the same thing...

@quinnj It looks like the generated struct looks like ```jl mutable struct Root A::Int64 end ``` which seems reasonable to me, is this an error with the reader?

Because the reader says this is an `Int64`, generate types gets the type information from that. If the examples are all safely castable to `Int`, that's what generate types will...

I think I like option 1. In this case we know that the number can be read as an Int, but when we try to read into an `Int` field...

`null` is currently represented in JSON3 as `nothing`, which is why the current handling of missingness shows those as the types. There are a couple of places where this is...