Michal Iwanow

Results 5 comments of Michal Iwanow

Fetch Marketplace promotions - ensure callback is always registered for `woocommerce_marketplace_fetch_promotions` action

@andfinally, @corsonr, after some refactoring that changes code from using Action Scheduler to rely on transients (and running code only in wp admin context), I made changes to PR description...

Fetch Marketplace promotions - ensure callback is always registered for `woocommerce_marketplace_fetch_promotions` action

@andfinally , nice catch with ``` register_deactivation_hook( WC_PLUGIN_FILE, array( __CLASS__, 'clear_scheduled_event' ) ); ``` I wanted to keep it but must have removed it by accident 🤦 Now I'm thinking...

Add Business services card

> It seems bigger (taller) featured images can break out of the card: I would suggest using image transformation params to ensure we don't load too big images: https://docs.wpvip.com/vip-file-system/image-files/transformations/ (apart...

Add Business services card

> wanted to check if we have to fire any tracks event similar to the one on WCCOM on the card click here? We should fire the same event as...

Fetch Marketplace promotions - ensure callback is always registered for `woocommerce_marketplace_fetch_promotions` action

I did one small change after @andfinally's review - minor lint fix, so I just amended the commit. In history it looks like it happened after @andfinally's review but 99%...