Matthew Kennedy

Results 55 issues of Matthew Kennedy

Some cylinders seem to not fire even though sync looks OK. Sequential mode: - Ignition 2/4 missing, but those cylinders get fuel. ![image](https://user-images.githubusercontent.com/568254/183264425-b52db069-ba54-44a0-b781-2e781ea1ec46.png) Wasted spark: - All looks normal, engine...

bug
not-actionable

Previously, we would only print one warning every N seconds, even if multiple were active. Now, we print every warning every N seconds, so that you don't miss any when...

Right now there's no indication of whether the ETB rev limit is active.

enhancement

Rate-of-return/deltaRPM based enable for idle logic, i.e. RPMs falling faster than X/second If RPM is headed toward idle quickly, enter idle before we actually get there. Can help avoid stalling...

idle

1. TPS/MAP/RPM enablers for boost control so solenoid isn't making noise at idle. Disable all boost control below thresholds (even open loop), as the turbo isn't possibly doing anything down...

enhancement

Looks like we copied something that ChibiOS already has - `BaseStaticThread`. Probably don't need `ThreadController` at all.

#4441 let's move forward fixes #4451

#4286 but happier

Use a separate 2d table (idle position vs. rpm) when throttle is closed, instead of the normal open loop position. Helps with coast down back to idle.

Add an option to use a separate 2d table when the idle controller has determined we are "coasting"

good first ticket
idle