Matthew Kennedy

Results 261 comments of Matthew Kennedy

I have no idea. It might be worth a refactor here anyway, is my point. Do we ever need the user to set "use only rise"? Can we force that...

this isn't done, the dbc needs updating

one more thing is to run tests in ci since there is no "just do it all" like running `ant` with no args

Sounds like Lua implementable to me

Was it? I didn't make that comment. In general, it's a bad idea to "launder" a value through the scaled_channel then back to a float. That's asking for precision to...

> I agree when it's scaled_channel but here we have scaled_channel which is a bit odd to begin with I don't know what the original problem was. Why was the...

This is due to a limitation in how we measure RPM. We have an "alternative" way of doing it too called "instant rpm" that looks much better in your log....

Lots of weird things are going on. Why is your MAP 120kPa? Turbo but only 3psi? Why is your accelerator pedal dropping out during the pull? Those RPM doublings are...

cam is OK, crank is maybe not OK. @ElDominio can you take a tunerstudio trigger log of cranking/starting? Your high RPM problem is also the primary wheel losing sync, nothing...

trigger log (the csv one), not a normal log