Matthew Kennedy

So, funny thing, I've flipped through our existing engine modules, and none directly reference another. There are no scenarios that we would call this new function.

those are all the steps I have - it does it for me on `master` Relatively normal linux pc. Checked in binary works fine. ConfigDefinition.jar built with the same command...

besides, we should already be cutting the main relay when the ignition voltage goes low

@ElDominio can you draw a rough diagram of: - ignition wire from key to ECU (and anything else relevant) - main relay wiring to/from ECU - main relay wiring to...

does the behavior still happen with USB connected? ie, can you log it?

After changing some wiring on my race car specifically in the name of increased safety during faults (if you crash, fuel pump should stop!), I think it's worthwhile doing this...

If the laptop is connected in that vid, can we get a TS log of that happening? I'm really curious what is going on there.

If the ignition pin keeps voltage on it, how would we know that it's turned off?

If you invert the vvt input (and adjust vvt offset to zero it out again), does that change the behavior? It's possible that one of the edges on the hall...

Not sure fully automatic is a very viable strategy. That's a great way to find some marginal condition (new combination of temperature/engine speed/whatever) that picks wrong and then your engine...