Matthew Kennedy

Results 261 comments of Matthew Kennedy

I'll have a look tonight with a debugger attached

> should this or something be deleting legacy code already? We could do that.

> My focus right now is on [ae8eb30](https://github.com/rusefi/rusefi/commit/ae8eb3073a4ecf0c4f056344e10286c8e0f09c05) Yes, that should be pretty easy shortly.

> I believe that this PR should be removing TsOutput that's still in use by the normal config generation, but not by live data

I don't understand your question. The live data tool as modified in this PR makes no call to TsOutput, but `gen_config.sh` does, so it isn't removed yet. `DataLogConsumer`, `OutputsSectionConsumer`, and...

As a temporary workaround, you can select 60-2, set "on camshaft", then put it back to the correct trigger. The ECU is looking at those settings even though you can't...

> @mck1117 what's the difference between F4 and F7 proteus builds? i am confused about .ini MSD options and where are those defined ![image](https://user-images.githubusercontent.com/568254/167731434-8f15d7cc-bb5b-44ca-b62f-14b043dbfadd.png) EFI_EMBED_INI_MSD is disabled on all F7.

The H7's ADC is fast enough to do that flip/sample/flip/sample *for the fast ADC*.

Do we need to on F4? What's wrong with the setup today on F4?