mchenryc

Current patch list: - [ ] freeciv_web_packets_def_changes - [ ] city_impr_fix2 - [ ] city-naming-change - [ ] metachange - [ ] text_fixes - [ ] unithand-change2 - [ ]...

@truberton you should submit a PR for your change, which will instigate the discussion of it. If you're not familiar with the fork-pull model used by freeciv-web, github has lots...

@lonemadmax is there confidence this can be closed, based on the above commit, and trackjs data?

At minimal, closure needs to be updated, as many improvements [have been made](https://github.com/google/closure-compiler/wiki/Releases), many to handle ES6 features, since the currently used v20170521 release.

**TL;DR:** I was looking at the right file - but hadn't realized the non-minified file is downloaded when hosted locally - IE was failing no matter what I did. I...

> Perhaps you can try adding support for transpiling using https://babeljs.io ? I might look into this. minify is no longer maintained, and the silliness above w/ closure-compiler was just...

I began a spike using babel with the maven build, which is, as might be expected, even more involved than using closure compiler plugin. More so, once the [src-dir cleanup](https://github.com/freeciv/freeciv-web/pull/186)...

Closed by mistake.

See [effects.c](https://github.com/freeciv/freeciv/blob/27a777a32ef0faa0bcca819c10f2fab4dcf15d51/common/effects.c) and [effects.h](https://github.com/freeciv/freeciv/blob/27a777a32ef0faa0bcca819c10f2fab4dcf15d51/common/effects.h) in the `freeciv` repository for additional info.

+1 for logging, and a vote for slf4j-api, which has adapters for other logging frameworks (or none). There is a good response on SO to the question: [Is it worth...