Matthew McEachen

Results 96 comments of Matthew McEachen

FWIW, you're missing an index on the `sess` and `expired` columns, and a primary key index on `sid`. `index.js` should be already doing this for you: https://github.com/ggcode1/connect-session-knex/blob/master/lib/index.js#L103

Wow, I didn't know it was so recent, I had just assumed they'd have produced those variants initially. I've seen both additional methods, as well as arguments, support this sort...

Thanks for opening this! If you haven't looked at it before, [electron-mocha](https://github.com/jprichardson/electron-mocha) [spawns electron](https://github.com/jprichardson/electron-mocha/blob/master/bin/electron-mocha#L34) with an [app](https://github.com/jprichardson/electron-mocha/blob/master/index.js#L44) that runs [mocha](https://github.com/jprichardson/electron-mocha/blob/master/mocha.js#L61).

> Other than the "sub-optimal" API design, what are the downsides to WorkerThreads over processes? It really depends on the host OS. * Processes are fairly cheap to spawn on...

(original author here, but realize it's been 6 years since I wrote this, and I'm no longer the maintainer). If you're not in a transaction, (depending on the rdbms, but...

With MySQL, if you're not in a txn, read results may not reflect the committed state of the database, depending on what engine you're using and how you've configured it.

(I'm too rusty with Rails at this point to give an opinion: this seems like an innocuous enough change, but either way, the documentation should be updated to highlight this...

> Why no answer for a year? Because this is a volunteer effort? The ClosureTree packages could benefit from more help: a couple people have stepped up, but more would...

Reopening-- @relwell, you're not on the hook for this. Anyone can submit a PR for it.